-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(cleanup) Kustomization #183
Conversation
1a7b65a
to
93613d4
Compare
93613d4
to
2cb65c0
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
=======================================
Coverage 87.02% 87.02%
=======================================
Files 3 3
Lines 131 131
=======================================
Hits 114 114
Misses 10 10
Partials 7 7 ☔ View full report in Codecov by Sentry. |
@@ -15,5 +15,4 @@ resources: | |||
- ../crd | |||
- ../rbac | |||
- ../manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there is also a prometheus directory that is unused. We do expose metrics that can be monitored via prometheus, but it seems like we haven't ever shipped the manifests with the ServiceMonitor
definition. Should we remove this and instead add some documentation with an example ServiceMonitor
that can be applied for grabbing metrics?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's a good idea +1. We should probably do the removal and subsequent documentation in a separate, single PR though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would vote to remove it now if it is extraneous. We can add it back (or examples) if/when someone asks for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Removed the prometheus
folder.
Closes operator-framework#155, operator-framework#160 Signed-off-by: Anik Bhattacharjee <[email protected]>
2cb65c0
to
32bd184
Compare
@joelanford done |
Closes #155, #160