Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fake metrics endpoint to make ODF happy #2391

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

tumido
Copy link
Member

@tumido tumido commented Sep 7, 2022

Related to: operate-first/support#652

Cherrypicking from @larsks OCP-on-NERC/nerc-ocp-config#18

While the "monitoring-endpoint" configuration in OCS 4.8 was optional,
it appears to be required in 4.10, and ODF refuses to deploy if it
can't reach the endpoint.

This commit provides a fake metrics endpoint to make the ODF operator
happy.

larsks and others added 2 commits September 7, 2022 14:41
While the "monitoring-endpoint" configuration in OCS 4.8 was optional,
it appears to be required in 4.10, and ODF refuses to deploy if it
can't reach the endpoint.

This commit provides a fake metrics endpoint to make the ODF operator
happy.
@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 7, 2022
@durandom
Copy link
Member

durandom commented Sep 7, 2022

thats funny. @redhat-et/storage any thoughts on this approach?
@guymguym / @cooktheryan not sure if ODF is also in your ballpark

lets
/approve
/lgtm
to make current ODF happy

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2022
@sesheta
Copy link
Member

sesheta commented Sep 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: durandom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2022
@sesheta sesheta merged commit ef85a73 into operate-first:master Sep 7, 2022
@yehudasa
Copy link

yehudasa commented Sep 7, 2022

@oritwas @jdurgin maybe there should be a better way to override ODF?

@yehudasa
Copy link

yehudasa commented Sep 8, 2022

@durandom @LarsK @tumido
According to @oritwas there are a couple of issues here. First, you're supposed to read the ceph-mgr export endpoint and use that one instead of the fake one that you provided.
The other issue, is that this should actually be optional according to the external mode docs. So will either need to fix the docs or fix the behavior. Can you open a jira ticket re this?

@tumido
Copy link
Member Author

tumido commented Sep 8, 2022

@yehudasa the problem here is that the external Ceph solution we use doesn't provide a metrics endpoint to users so we don't have access to it.

Is there a settings for StorageCluster where we can disable ODF contacting the metrics endpoint?

ODF refuses to create the storage cluster unless it can contact metrics endpoint in the external mode.

@tumido
Copy link
Member Author

tumido commented Sep 8, 2022

@yehudasa Which project in Jira should I use for the ticket?

@durandom
Copy link
Member

pinged @yehudasa via chat

@tumido
Copy link
Member Author

tumido commented Sep 22, 2022

@yehudasa I think it's not optional, however the docs are a bit confusing about this:

image

Anyways, opened a BZ here: https://bugzilla.redhat.com/show_bug.cgi?id=2129117

@tumido tumido deleted the add-fake-metrics-exporter branch November 2, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants