ui: ensures resources loaded by relative URL when ZIPKIN_UI_BASEPATH set #3746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
commented
Mar 5, 2024
| @@ -1,7 +1,7 @@ | |||
| <!-- simplified version of /zipkin-lens/index.html --> | |||
| <html> | |||
| <head> | |||
| <base href="/zipkin/"> | |||
There was a problem hiding this comment.
the actual source has no trailing slash
|
locally seems to match old behavior. also the UI functions fine without this property $ curl -s localhost:9411/zipkin/index.html |tidy -q -i --tidy-mark no --wrap 1024
line 18 column 3 - Warning: inserting missing 'title' element
<!--
Copyright 2015-2024 The OpenZipkin Authors
Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
in compliance with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software distributed under the License
is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
or implied. See the License for the specific language governing permissions and limitations under
the License.
-->
<!DOCTYPE html>
<html>
<head>
<base href="/admin/zipkin">
<meta charset="utf-8">
<link rel="icon" href="./favicon.ico">
<script type="module" crossorigin="" src="./static/js/index.6af42604.js"></script>
<link rel="stylesheet" href="./static/css/index.a7aa86b4.css">
<title></title>
</head>
<body>
<noscript>You need to enable JavaScript to run this app.</noscript>
<div id="root"></div>
</body>
</html> |
anuraaga
approved these changes
Mar 5, 2024
codefromthecrypt
changed the title
|
thanks for the look @anuraaga! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per #3742 (comment) we aren't there, yet