ci: adds lint check and fixes bad links and yaml formatting #3689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
besides normal motivation, one is to make sure things pass before adding new links for #3649 |
reta
approved these changes
Jan 14, 2024
codefromthecrypt
force-pushed
the
lint
branch
from
fd1df82
to
294b166
Compare
added 2 commits
January 14, 2024 10:20
We should quote any example links and only add links for things that are always up, or will be up due following instructions. For example, we should add exceptions for localhost services that run in result of test commands for zipkin or the UI. See openzipkin/zipkin-gcp#212 for the first impl of this. Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
force-pushed
the
lint
branch
from
7f1c2f3
to
935d8df
Compare
added 2 commits
January 14, 2024 12:30
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
changed the title
|
I refactored this to be coherent with the other steps we do like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new scripts
configure_lintandlintwhich work like our other build-bin scripts. These lint the workflow yaml and our markdown links.I also removed the separate step for javadoc checking as it is easy to do that in the release test target, as well uses less resources vs doing it twice.
See openzipkin/zipkin-gcp#212 for the first impl of this. I will propagate the same style elsewhere after.