Remove null characters in any string passed to the container / debug task #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #997 +/- ##
==========================================
+ Coverage 88.14% 88.23% +0.09%
==========================================
Files 94 95 +1
Lines 5312 5329 +17
==========================================
+ Hits 4682 4702 +20
+ Misses 630 627 -3 ☔ View full report in Codecov by Sentry. |
rgaudin
approved these changes
Jul 23, 2024
benoit74
force-pushed
the
remove_null_chars
branch
from
cf55011 to
f7e9e16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Fix #955
Changes
containeranddebugtask properties have\u0000character removed ; for now, other control characters are kept since they do not pose a problem from DB perspective (see Remove all control characters in task properties #998 for the potential next step)