Add new CLI arguments for Zimit/Warc2zim 2.0.2 #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I just spotted a silly mistake |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #984 +/- ##
=======================================
Coverage 88.12% 88.13%
=======================================
Files 94 94
Lines 5304 5308 +4
=======================================
+ Hits 4674 4678 +4
Misses 630 630 ☔ View full report in Codecov by Sentry. |
|
This is ready for review again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Add new arguments in Zimit offliner definition, following the release of Zimit/Warc2zim 2.0.2
Nota: this will also be deployed on farm.zimit.kiwix.org where we still do not use 2.x, and on recipes of farm.openzim.org which are still in 1.x ; this is assumed to be mostly harmless since it has no impact if options are not specified, and none of them are required.