Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade receiver and workers #929

Merged
merged 11 commits into from
Feb 29, 2024
Merged

Upgrade receiver and workers #929

merged 11 commits into from
Feb 29, 2024

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Feb 27, 2024

Rationale

Maintenance

Changes

  • Upgrade receiver:
    • Upgrade to Python 3.12 + Debian slim bookworm
    • Upgrade to Jailkit 2.23
  • Upgrade task worker:
    • Upgrade to Python 3.12 + Debian slim bookworm
    • Upgrade and pin Python dependencies
  • Upgrade worker manager:
    • Upgrade to Python 3.12 + Debian slim bookworm
    • Upgrade and pin Python dependencies
  • Fix small bug in receiver get_zimfarm_key.py usage
  • Adapt development docker-compose:
    • remove ssh-host: this should have been the receiver from the beginning
    • add receiver
      • including helper script to create all required warehouse paths
    • add commented worker manager and task worker
    • add instructions in dev/README.md
    • add contrib script to create a worker / start first requested task
    • fix backend configuration to upload all artifacts to receiver
    • fix uploader tests to use receiver instead of ssh-host
  • trigger a rebuild of dnscache
  • modify task worker to use latest images of dnscache, uploader
  • remove zmq for worker dependencies + corresponding files

Open point: is it normal that we need to create all warehouse paths in the receiver manually ? This is not part of the procedure to create a new warehouse path, so I'm a bit surprised

@benoit74 benoit74 self-assigned this Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.84%. Comparing base (ecee845) to head (ded4301).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #929   +/-   ##
=======================================
  Coverage   87.84%   87.84%           
=======================================
  Files          93       93           
  Lines        5297     5297           
=======================================
  Hits         4653     4653           
  Misses        644      644           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 force-pushed the upgrade_receiver_workers branch from 269417a to adaddab Compare February 27, 2024 09:14
@benoit74 benoit74 marked this pull request as ready for review February 27, 2024 09:31
@benoit74 benoit74 requested a review from rgaudin February 27, 2024 09:31
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

workers/manager-Dockerfile Outdated Show resolved Hide resolved
workers/task-requirements.txt Outdated Show resolved Hide resolved
dev/contrib/create_worker.sh Show resolved Hide resolved
dev/contrib/start_first_req_task.sh Show resolved Hide resolved
@benoit74 benoit74 requested a review from rgaudin February 29, 2024 08:29
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@rgaudin rgaudin merged commit f1f2327 into main Feb 29, 2024
7 checks passed
@rgaudin rgaudin deleted the upgrade_receiver_workers branch February 29, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants