Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not request all schedules details at once, proceed in small batches #884

Merged
merged 5 commits into from
Dec 12, 2023

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Dec 12, 2023

Rationale

Fix #882

Changes

  • when getting schedules information for the tasks details, we proceed in batches of 5 requests every 500 ms
  • when the data is refreshed (scheduled refresh every minute, or when the number of tasks to display is changed), details about schedules are hidden until all data is loaded
  • Bump @babel/traverse from 7.12.12 to 7.23.2 in /dispatcher/frontend-ui
  • Bump browserify-sign from 4.2.1 to 4.2.2 in /dispatcher/frontend-ui
  • Bump axios from 0.21.2 to 1.6.0 in /dispatcher/frontend-ui

@benoit74 benoit74 self-assigned this Dec 12, 2023
@benoit74 benoit74 marked this pull request as ready for review December 12, 2023 09:39
@benoit74 benoit74 requested a review from rgaudin December 12, 2023 09:39
dependabot bot added 3 commits December 12, 2023 10:41
Bumps [axios](https://github.com/axios/axios) from 0.21.2 to 1.6.0.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v0.21.2...v1.6.0)

---
updated-dependencies:
- dependency-name: axios
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [browserify-sign](https://github.com/crypto-browserify/browserify-sign) from 4.2.1 to 4.2.2.
- [Changelog](https://github.com/browserify/browserify-sign/blob/main/CHANGELOG.md)
- [Commits](browserify/browserify-sign@v4.2.1...v4.2.2)

---
updated-dependencies:
- dependency-name: browserify-sign
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.12.12 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
dispatcher/frontend-ui/src/constants.js Outdated Show resolved Hide resolved
dispatcher/frontend-ui/src/constants.js Outdated Show resolved Hide resolved
dispatcher/frontend-ui/src/components/PipelineTable.vue Outdated Show resolved Hide resolved
@benoit74 benoit74 requested a review from rgaudin December 12, 2023 12:34
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good ; I'll let you merge once you've updated the ui configs so those values are explicit and can be changed easily

@benoit74 benoit74 merged commit 9672e25 into main Dec 12, 2023
5 checks passed
@benoit74 benoit74 deleted the not_overhelm branch December 12, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop overwhelming the API with hundreds of requests in parallel
2 participants