Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix update of worker last_seen property #875

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Fix update of worker last_seen property #875

merged 3 commits into from
Nov 27, 2023

Conversation

benoit74
Copy link
Collaborator

Rationale

Changes

  • always commit changes to DB, not only if worker IP has changed
  • in tests, move stuff to fixtures + perform tests around last_seen and last_ip updates

@benoit74 benoit74 self-assigned this Nov 27, 2023
@benoit74 benoit74 requested a review from rgaudin November 27, 2023 09:02
@benoit74 benoit74 marked this pull request as ready for review November 27, 2023 09:02
rgaudin
rgaudin approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good ; please update the comment and merge

dispatcher/backend/src/tests/integration/routes/workers/test_worker.py Outdated Show resolved Hide resolved
dispatcher/backend/src/routes/requested_tasks/requested_task.py Outdated Show resolved Hide resolved
@benoit74 benoit74 merged commit ae32fb6 into main Nov 27, 2023
5 checks passed
@benoit74 benoit74 deleted the fix_last_seen_update branch November 27, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaudin rgaudin rgaudin approved these changes

Assignees

@benoit74 benoit74

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benoit74 @rgaudin