-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat:Added field to show automatic scheduling status #873
Feat:Added field to show automatic scheduling status #873
Conversation
@gpuligundla do you confirm this is ready for review? |
NOTA: I updated your first comment to use the "Fix #xxx" syntax, so that the issue will automatically be closed when the PR is merged |
yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please do not merge main
into your branch to retrieve changes, instead rebase your branch on top of latest main
changes (typically with git rebase main
when on your branch). This is a highly debatable choice of course, but it is our convention ^^
Thank you for this very good first PR anyway.
b440f31
to
0590f63
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I'm just asking @rgaudin for a final pass since he has more expertise than me on this kind of UI stuff and previous discussions that occurred on the Zimfarm.
Just to clarify a bit the PR workflow (detailed in https://github.com/openzim/overview/wiki/openZIM-workflow), especially regarding changes on main branch while you are developing for all openzim/kiwix/offspot repos:
But again, don't be afraid of all this, this is just small conventions to facilitate everyone asynchronous work, avoid misunderstandings and your help is still valuable and welcomed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ; thank you for this great first contribution 👍
sure, I'll follow it from next time. Thanks <3 |
0590f63
to
47d7918
Compare
Rationale
Fix #816
Changes
enabled
field to schedulelight schema & retrieved its value from Postgres.pause
icon to show it in the front end.Screenshot: