Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes to small bugs #837

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Small fixes to small bugs #837

merged 2 commits into from
Sep 29, 2023

Conversation

benoit74
Copy link
Collaborator

Rationale

Fix #821
Fix #798

Changes

  • Secrets removal is more robust to "malformed" JSON data
  • Fix OpenAPI example value for UUIDs

@benoit74 benoit74 self-assigned this Sep 29, 2023
@benoit74 benoit74 requested a review from rgaudin September 29, 2023 08:15
@benoit74 benoit74 marked this pull request as ready for review September 29, 2023 08:24
rgaudin
rgaudin approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rgaudin rgaudin merged commit e55ffc9 into main Sep 29, 2023
5 checks passed
@rgaudin rgaudin deleted the various_fixes branch September 29, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaudin rgaudin rgaudin approved these changes

Assignees

@benoit74 benoit74

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

500 error in remove_upload_secrets when upload is None Fix _id sample value in OpenAPI documentation
2 participants
@benoit74 @rgaudin