Enhance offliners definitions #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit74
force-pushed
the
enhance_offliners_defs
branch
2 times, most recently
from
b98e374 to
25ed6d9
Compare
This will enhance the UI by issuing a combobox instead of a text field
benoit74
force-pushed
the
enhance_offliners_defs
branch
from
25ed6d9 to
35a4d4c
Compare
rgaudin
requested changes
Sep 28, 2023
benoit74
force-pushed
the
enhance_offliners_defs
branch
from
7ba211a to
ad6c5a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Changes
descriptionandlong_descriptionfields are now checked with the appropriate validatorlong_descriptionare now aLongStringfield, so that the UI is populated properly with a text arealanguagefield is now validated with aoneofvalidator, which will be reflected in the/offlinersAPI as achoicesproperty and in the UI as a combobox instead of a text fieldfields.Stringare replaced by a customStringwhich forbids the presence of Unicode null character in the value at validation ; this allows to fix issue for all API endpoints, even if some values would have been rejected by postgreSQL (unicode null string is not allowed in VARCAHR columns, but it is in JSON columns) it allows for much nicer error messages