Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing cancel requester #831

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Missing cancel requester #831

merged 3 commits into from
Sep 28, 2023

Conversation

benoit74
Copy link
Collaborator

Rationale

Fix #814

Changes

  • fix logic to set canceled_by property when the cancel event is received and this property was not already set by a cancel requester
  • fix UI to show canceled_by property on the cancel_requestedevent when the cancellation is not yet effective (otherwise the property is not visible until the cancellation is effective, even if present in the API)
  • fix a misleading variable named reserved_by instead of canceled_by in utils.py

@benoit74
Copy link
Collaborator Author

benoit74 commented Sep 26, 2023 •
edited
Loading

Draft because based on missing_schedule_name branch which is waiting to be reviewed/merged

=> rebase required once this branch is merged

@benoit74 benoit74 self-assigned this Sep 26, 2023
@benoit74 benoit74 force-pushed the missing_cancel_requester branch from 9578e55 to 233ea7f Compare September 28, 2023 05:41
@benoit74 benoit74 marked this pull request as ready for review September 28, 2023 06:17
@benoit74 benoit74 requested a review from rgaudin September 28, 2023 06:17
rgaudin
rgaudin requested changes Sep 28, 2023
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the annoying simulation of this in the test 👍
Please add a few comments as suggested inline. This will greatly help future us I predict 😉

dispatcher/backend/src/tests/integration/routes/business_logic/test_task_cancel_bl.py Show resolved Hide resolved
dispatcher/backend/src/tests/integration/routes/business_logic/test_task_cancel_bl.py Show resolved Hide resolved
dispatcher/backend/src/tests/integration/routes/business_logic/test_task_cancel_bl.py Outdated Show resolved Hide resolved
dispatcher/backend/src/tests/integration/routes/business_logic/test_task_cancel_bl.py Outdated Show resolved Hide resolved
@benoit74 benoit74 requested a review from rgaudin September 28, 2023 13:51
@rgaudin rgaudin force-pushed the missing_cancel_requester branch from b338c91 to 48be807 Compare September 28, 2023 13:58
rgaudin
rgaudin approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rgaudin rgaudin merged commit edbaa7d into main Sep 28, 2023
@rgaudin rgaudin deleted the missing_cancel_requester branch September 28, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaudin rgaudin rgaudin approved these changes

Assignees

@benoit74 benoit74

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cancel-requester not shown
2 participants
@benoit74 @rgaudin