Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new flags to mindtouch scraper #1051

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Add new flags to mindtouch scraper #1051

merged 1 commit into from
Nov 19, 2024

Conversation

benoit74
Copy link
Collaborator

Rationale

Mindtouch scraper needs new flags

@benoit74 benoit74 self-assigned this Nov 19, 2024
@benoit74 benoit74 marked this pull request as ready for review November 19, 2024 07:56
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.42%. Comparing base (3194ca6) to head (2d77492).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1051   +/-   ##
=======================================
  Coverage   88.41%   88.42%           
=======================================
  Files          98       98           
  Lines        5449     5451    +2     
=======================================
+ Hits         4818     4820    +2     
  Misses        631      631           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@benoit74 benoit74 requested a review from rgaudin November 19, 2024 07:56
@benoit74
Copy link
Collaborator Author

@rgaudin feedback welcomed, but I will merge right away to save back-and-forth, it is so straigthforward

@benoit74 benoit74 merged commit 7459c1a into main Nov 19, 2024
7 checks passed
@benoit74 benoit74 deleted the mindtouch branch November 19, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant