Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new --logo-format argument to devdocs scraper #1047

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

benoit74
Copy link
Collaborator

Rationale

Devdocs 0.2.0 has a new argument we should expose

@benoit74 benoit74 self-assigned this Nov 14, 2024
@benoit74 benoit74 marked this pull request as ready for review November 14, 2024 09:01
@benoit74 benoit74 requested a review from rgaudin November 14, 2024 09:01
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (c0eb265) to head (d27ba91).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1047   +/-   ##
=======================================
  Coverage   88.41%   88.41%           
=======================================
  Files          98       98           
  Lines        5447     5448    +1     
=======================================
+ Hits         4816     4817    +1     
  Misses        631      631           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 merged commit 040a78d into main Nov 14, 2024
7 checks passed
@benoit74 benoit74 deleted the offliner_defs branch November 14, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants