Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mindtouch offliner for libretexts.org #1038

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Add mindtouch offliner for libretexts.org #1038

merged 1 commit into from
Oct 31, 2024

Conversation

benoit74
Copy link
Collaborator

Rationale

We have a new scraper.

I propose to create:

  • one new offliner ...
  • one new category mindtouch
  • two new warehouse paths libretexts (for libretexts.org ZIMs) and mindtouch (for other mindtouch ZIMs we might create)
  • one new platform libretexts to limit to 1 job at a time on the whole zimfarm

@benoit74 benoit74 self-assigned this Oct 29, 2024
@benoit74 benoit74 marked this pull request as ready for review October 29, 2024 14:21
@benoit74 benoit74 requested a review from rgaudin October 29, 2024 14:21
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (fa98354) to head (63a5880).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1038      +/-   ##
==========================================
+ Coverage   88.35%   88.41%   +0.06%     
==========================================
  Files          97       98       +1     
  Lines        5417     5447      +30     
==========================================
+ Hits         4786     4816      +30     
  Misses        631      631              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 requested a review from kelson42 October 29, 2024 14:21
@benoit74
Copy link
Collaborator Author

@kelson42 we need your feedback on categories / warehouse path at least ... not on the code itself obviously

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ; no opinion on the values

@rgaudin rgaudin self-requested a review October 29, 2024 15:18
@benoit74 benoit74 merged commit 9d43704 into main Oct 31, 2024
7 checks passed
@benoit74 benoit74 deleted the add_mindtouch branch October 31, 2024 09:35
@benoit74
Copy link
Collaborator Author

Warehouse paths created manually on the receiver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants