Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Devdocs offliner, category and warehouse path #1020

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Add Devdocs offliner, category and warehouse path #1020

merged 2 commits into from
Sep 27, 2024

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Sep 24, 2024

Rationale

Add new devdocs offliner, including new category (since we do not yet know which category list we want to use) and new warehouse path.

Also add new platform since we do not want to run more than one task per worker (but without global limit on the farm). See setting for our prod in kiwix/operations#263

Nota: while we have not yet released a 0.1, this is coming soon and this code should be ok to deploy since anyway we already have a dev Docker image at https://github.com/openzim/devdocs/pkgs/container/devdocs

@benoit74 benoit74 self-assigned this Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.34%. Comparing base (72481c2) to head (4547867).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1020      +/-   ##
==========================================
+ Coverage   88.29%   88.34%   +0.05%     
==========================================
  Files          96       97       +1     
  Lines        5389     5413      +24     
==========================================
+ Hits         4758     4782      +24     
  Misses        631      631              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 marked this pull request as ready for review September 24, 2024 11:02
@benoit74 benoit74 requested a review from rgaudin September 24, 2024 11:02
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Category and warehouse paths require a decision. I haven't heard we're creating either for devdocs and so until then this should be other for both I believe.

Excuse my questions if some doesn't make sense ; I haven't used the scraper yet.

@kelson42
Copy link
Contributor

Category and warehouse paths require a decision. I haven't heard we're creating either for devdocs and so until then this should be other for both I believe.

Supportive of a dedicated Category and storage path.

@benoit74 benoit74 requested a review from rgaudin September 26, 2024 09:00
@benoit74
Copy link
Collaborator Author

@rgaudin do not hesitate to ask for live call to settle on open discussions

Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think everything's settled but you did not re-request… approved anyway

@benoit74
Copy link
Collaborator Author

Of course I did ^^
image

@benoit74 benoit74 merged commit 7a44cc9 into main Sep 27, 2024
6 checks passed
@benoit74 benoit74 deleted the devdocs branch September 27, 2024 09:22
@rgaudin
Copy link
Member

rgaudin commented Sep 27, 2024

Do you have a timestamped attorney-certified copy of that? 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants