Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relaxed nautilus schema #1004

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Relaxed nautilus schema #1004

merged 4 commits into from
Jul 29, 2024

Conversation

rgaudin
Copy link
Member

@rgaudin rgaudin commented Jul 29, 2024

As for zimit.kiwix.org, we want the ZIM as a service to produce ZIM file via the
api.farm.zimit.kiwix.org backend without the zim-file constraint of the period.

Duplicated the zimit tests to prevent regression but it serves no other purpose.

rgaudin added 2 commits July 29, 2024 12:15
As for zimit.kiwix.org, we want the ZIM as a service to produce ZIM file via the
api.farm.zimit.kiwix.org backend without the zim-file constraint of the period.

Duplicated the zimit tests to prevent regression but it serves no other purpose.
@rgaudin rgaudin self-assigned this Jul 29, 2024
@rgaudin rgaudin changed the title Relaxed nautilus Relaxed nautilus schema Jul 29, 2024
@rgaudin rgaudin requested a review from benoit74 July 29, 2024 12:19
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.27%. Comparing base (6767766) to head (c6e683b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1004      +/-   ##
==========================================
+ Coverage   88.21%   88.27%   +0.05%     
==========================================
  Files          95       96       +1     
  Lines        5329     5356      +27     
==========================================
+ Hits         4701     4728      +27     
  Misses        628      628              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@benoit74 benoit74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few minor comments, I let you decide what to do with them then merge.

@rgaudin rgaudin merged commit 4d90e63 into main Jul 29, 2024
7 checks passed
@rgaudin rgaudin deleted the relaxed-nautilus branch July 29, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants