Merge pull request #1019 from openzim/remove_secrets

Make URL secrets removal more resilient
openzim · Sep 20, 2024 · 72481c2 · 72481c2
2 parents 27fac52 + 3b3f87c
commit 72481c2
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/dispatcher/backend/src/routes/utils.py b/dispatcher/backend/src/routes/utils.py
@@ -103,7 +103,13 @@ def remove_url_secrets(response: dict):
             if not isinstance(response[key], str) or "://" not in response[key]:
                 continue
             for url in [word for word in response[key].split() if "://" in word]:
-                urlparts = urlsplit(url)
+                try:
+                    urlparts = urlsplit(url)
+                except Exception as exc:
+                    logger.warning(
+                        f"Ignoring bad URL in remove_url_secrets: {url}", exc_info=exc
+                    )
+                    continue
                 newquery = urlencode(
                     {
                         key: (