Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deb CI and clarify minimum libzim version needed #427

Merged
merged 2 commits into from
Sep 1, 2024

Conversation

kelson42
Copy link
Contributor

@kelson42 kelson42 commented Sep 1, 2024

Libzim 9.2.0 is the bare minimum version needed to compile/run the ZIM tools. Unfortunately this is still nowhere available in Debian, so we have to comment-out the CI for Debian packages (but not for Ubuntu)

See #428 for the follow-up on Debian

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.01%. Comparing base (b6fe360) to head (42712cc).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #427   +/-   ##
=======================================
  Coverage   27.01%   27.01%           
=======================================
  Files          26       26           
  Lines        2458     2458           
  Branches     1339     1339           
=======================================
  Hits          664      664           
  Misses       1305     1305           
  Partials      489      489           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42 kelson42 changed the title Be precise about libzim version required Fix deb CI and clarify minimum libzim version needed Sep 1, 2024
@kelson42 kelson42 merged commit 06b9916 into main Sep 1, 2024
12 checks passed
@kelson42 kelson42 deleted the precise-min-libzim-version branch September 1, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant