Use open_objset() when using close_objset() #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lundman Hmm, strange somehow openzfsonosx/openzfs@701f0ee disappeared. A freshly checked out zol_crypto is still at Any idea? |
|
Ah yeah, I don't think I meant to merge them just yet, but leave them for review, my apologies, you may need to PR again |
|
No that's fine. I was just a bit confused: saw the commit, went to bed, woke up and the commit was gone. It would perfectly make sense to bundle it with openzfsonosx/openzfs#3. Unfortunately I'm not familiar with the GitHub workflow, how would I ask for review now? I would appreciate any advice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the zdb panic triggered by ztest. With this patch zloop produced no errors in seven hours (232 iterations).