Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define HAVE_KERNEL_NEON as (0) if not defined for simd_stat #16558

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

w0xel
Copy link
Contributor

@w0xel w0xel commented Sep 23, 2024

Motivation and Context

Currently does not build for aarch64 on linux >= 6.2, as HAVE_KERNEL_NEON will not be defined, but used in simd_stat.c.

Description

This adds the HAVE_KERNEL_NEON to simd_stat.c defaulted to 0 to make it build again.

How Has This Been Tested?

Built for aarch64 with latest master before, does not build with error: 'HAVE_KERNEL_NEON' undeclared.

Built for aarch64 again with this patch, does build again.

No other builds or tests were done.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Signed-off-by: Sebastian Wuerl [email protected]

Requires-builders: style arch

Copy link
Contributor

@Harry-Chen Harry-Chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please fix the checkstyle workflow by adding signed-off-by to your commit message.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Sep 23, 2024
@Harry-Chen
Copy link
Contributor

I happened to see this comment: 1d84c9e#commitcomment-147049188

So we may need such guard for each macro used in simd_stat.c, since any of them could be undefined in different cases.

@w0xel w0xel force-pushed the hotfix/simd_stat_missing_define branch from 38f7d00 to 95e6aad Compare September 23, 2024 18:25
module/zcommon/simd_stat.c Show resolved Hide resolved
@w0xel w0xel force-pushed the hotfix/simd_stat_missing_define branch from 95e6aad to 801c258 Compare September 23, 2024 19:47
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Sep 23, 2024
@behlendorf behlendorf merged commit ccc420a into openzfs:master Sep 24, 2024
16 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants