ZTS: add Ubuntu 20.04, 22.04 and 24.04 to the QEMU tests

.github/workflows/checkstyle.yaml

@@ -13,15 +13,11 @@ jobs:
         ref: ${{ github.event.pull_request.head.sha }}
     - name: Install dependencies
       run: |
-        # https://github.com/orgs/community/discussions/47863
-        sudo apt-mark hold grub-efi-amd64-signed
-        sudo apt-get update --fix-missing
-        sudo apt-get upgrade
-        sudo xargs --arg-file=${{ github.workspace }}/.github/workflows/build-dependencies.txt apt-get install -qq
-        sudo xargs --arg-file=${{ github.workspace }}/.github/workflows/checkstyle-dependencies.txt apt-get install -qq
-        sudo python3 -m pip install --quiet flake8
-        sudo apt-get clean
-
+        # for x in lxd core20 snapd; do sudo snap remove $x; done
+        sudo apt-get purge -y snapd google-chrome-stable firefox
+        ONLY_DEPS=1 .github/workflows/scripts/qemu-3-deps.sh ubuntu22
+        sudo apt-get install -y cppcheck devscripts mandoc pax-utils shellcheck
+        sudo python -m pipx install --quiet flake8
         # confirm that the tools are installed
         # the build system doesn't fail when they are not
         checkbashisms --version
@@ -31,8 +27,13 @@ jobs:
         shellcheck --version
     - name: Prepare
       run: |
+        sed -i '/DEBUG_CFLAGS="-Werror"/s/^/#/' config/zfs-build.m4
         ./autogen.sh
+    - name: Configure
+      run: |
         ./configure
+    - name: Make
+      run: |
         make -j$(nproc) --no-print-directory --silent
     - name: Checkstyle
       run: |

.github/workflows/scripts/qemu-3-deps.sh

@@ -141,6 +141,10 @@ case "$1" in
     ;;
 esac
 
+# This script is used for checkstyle + zloop deps also.
+# Install only the needed packages and exit - when used this way.
+test -z "${ONLY_DEPS:-}" || exit 0
+
 # Start services
 echo "##[group]Enable services"
 case "$1" in

.github/workflows/scripts/qemu-7-prepare.sh

@@ -46,7 +46,11 @@ for i in $(seq 1 $VMs); do
   test -s $file && mv -f $file uname.txt
 
   file="vm$i/tests-exitcode.txt"
-  test -s $file || echo 1 > $file
+  if [ ! -s $file ]; then
+    # XXX - add some tests for kernel panic's here
+    # tail -n 80 vm$i/console.txt | grep XYZ
+    echo 1 > $file
+  fi
   rv=$(cat vm$i/tests-exitcode.txt)
   test $rv != 0 && touch /tmp/have_failed_tests
 
@@ -89,7 +93,6 @@ fi
 cat summary.txt \
   | awk '/\(expected PASS\)/{ if ($1!="SKIP") print $2; next; } show' \
   | while read t; do
-  echo "check: $t"
   cat summary-failure-logs.txt \
     | awk '$0~/Test[: ]/{ show=0; } $0~v{ show=1; } show' v="$t" \
     > /tmp/fail.txt

.github/workflows/scripts/qemu-8-summary.sh

@@ -35,15 +35,12 @@ EOF
 cat /tmp/summary.txt
 echo ""
 
-if [ -e /tmp/have_failed_tests ]; then
-  RV=1
+if [ -f /tmp/have_failed_tests -a -s /tmp/failed.txt ]; then
   echo "Debuginfo of failed tests:"
   cat /tmp/failed.txt
   echo ""
   cat /tmp/summary.txt | grep -v '^/'
   echo ""
-else
-  RV=0
 fi
 
 echo -e "\nFull logs for download:\n    $1\n"
@@ -70,4 +67,5 @@ for i in $(seq 1 $VMs); do
   test -s "$file" && showfile "$file" "$vm: failure logfile"
 done
 
-exit $RV
+test -f /tmp/have_failed_tests && exit 1
+exit 0