Linux: bump minimum kernel version to 4.18 #16479

robn · 2024-08-26T11:31:05Z

Motivation and Context

I started cutting things out in #16434. Everyone loved it, and wanted more. I'm nothing if not a crowd pleaser!

Description

Just like last time, but this time the minimum is 4.18, as the base kernel for RHEL8.

Since last time, more stuff removed. Following comments there, I've left DECLARE_EVENT_CLASS, and the baseline checks.

How Has This Been Tested?

Compile checked on kernel.org kernels:

4.19.319
5.4.281
5.10.223
5.15.164
6.1.102
6.2.16
6.3.13
6.4.16
6.5.13
6.6.43
6.7.12
6.8.12
6.9.12
6.10.3
6.11.0

And on following distros:

5.4.0-84-generic (Ubuntu 18.04)
5.13.0-30-generic (Ubuntu 20.04)
5.15.0-25-generic (Ubuntu 22.04)
6.8.0-31-generic (Ubuntu 24.04)
4.18.0-348.7.1.el8_5.x86_64 (CentOS 8.4.2105)
4.18.0-553.8.1.el8_10.x86_64 (Rocky 8.6)
5.14.0-427.28.1.el9_4.x86_64 (Rocky 9)
6.10.5-200.fc40.x86_64 (Fedora 40)

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Performance enhancement (non-breaking change which improves efficiency)
Code cleanup (non-breaking change which makes code smaller or more readable)
Breaking change (fix or feature that would cause existing functionality to change)
Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
Documentation (a change to man pages or other documentation)

Checklist:

My code follows the OpenZFS code style requirements.
I have updated the documentation accordingly.
I have read the contributing document.
I have added tests to cover my changes.
I have run the ZFS Test Suite with this change applied.
All commit messages are properly formatted and contain Signed-off-by.

tonyhutter · 2024-09-05T17:04:59Z

Did you intend to remove config/intlmacosx.m4?

config/kernel-config-defined.m4

tonyhutter · 2024-09-05T18:29:12Z

Other than my comments above, I don't see any issues. Thank you for all this hard work!

robn · 2024-09-06T09:55:30Z

Did you intend to remove config/intlmacosx.m4?

Yes. Again, I can't see that anything ever used the defines (HAVE_CFPREFERENCESCOPYAPPVALUE, HAVE_CFLOCALECOPYCURRENT, HAVE_CFLOCALECOPYPREFERREDLANGUAGES) or the substitution (INTL_MACOSX_LIBS), and there's nothing in the history to suggest why it was added.

tonyhutter · 2024-09-10T16:13:40Z

Its general cleanups - nothing checks the ZFS_IS_GPL_COMPATIBLE, and I can't see that anything ever did.

Again, I can't see that anything ever used the defines (HAVE_CFPREFERENCESCOPYAPPVALUE, HAVE_CFLOCALECOPYCURRENT, HAVE_CFLOCALECOPYPREFERREDLANGUAGES) or the substitution (INTL_MACOSX_LIBS), and there's nothing in the history to suggest why it was added.

Ah I see now. Yea, looks like dead code, let's keep it removed.

mcmilk

Needs a rebase and some mods within these files:
./module/os/linux/zfs/zpl_file.c
./config/kernel-vfs-direct_IO.m4
./config/kernel.m4
./config/kernel-vfs-iov_iter.m4

LGTM 👍

robn · 2024-09-16T01:19:17Z

Yep, was on it last night but I got tired.

Last push rebased. Compile checks have been redone (kernel versions updated in original post), and results checked again.

I've got a couple more rounds of testing in progress just to be totally sure, but I'm pretty confident this is good.

(update: lgtm)

behlendorf · 2024-09-16T16:43:10Z

Thanks for the quick rebase of this Rob. I'll review this today so we can get it in.

amotin · 2024-09-16T20:07:27Z

As I have mentioned in the Direct I/O PR, it seems config/kernel-get-user-pages.m4 added there could be completely removed.

mcmilk · 2024-09-17T08:33:03Z

Debian 11 seems to have problems:

Since the two runs fail the same way, there seems sth. bad to happen :(

behlendorf · 2024-09-17T16:53:00Z

@mcmilk good catch, I see things are passing in with Debian 11 in your QEMU PR against master so this does seem like a regression. Passing CI run, https://github.com/openzfs/zfs/actions/runs/10899160824/job/30243940242

It does look we we can shed config/kernel-get-user-pages.m4 but we can always follow up with a PR for this.

robn · 2024-09-17T23:42:05Z

Kernel for Debian 11 builders appears to be 5.10.223. That's in my test set, so it builds and passes basic sanity checks, so most likely I've removed something that caused it to use a non-working fallback or something like that. I'll check it out today or tomorrow.

This sets RHEL8's base kernel[1] as the floor, and includes the oldest kernel.org LTS (4.19). 1. https://access.redhat.com/articles/3078#RHEL8 Sponsored-by: https://despairlabs.com/sponsor/ Signed-off-by: Rob Norris <[email protected]>

All of these set a #define that doesn't appear anywhere in the tree. Sponsored-by: https://despairlabs.com/sponsor/ Signed-off-by: Rob Norris <[email protected]>

Sponsored-by: https://despairlabs.com/sponsor/ Signed-off-by: Rob Norris <[email protected]>

Sponsored-by: https://despairlabs.com/sponsor/ Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Tony Hutter <[email protected]> Reviewed-by: Tino Reichardt <[email protected]> Signed-off-by: Rob Norris <[email protected]> Closes #16479

get_user_pages_unlocked() had stabilised by 4.9. Sponsored-by: https://despairlabs.com/sponsor/ Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Tony Hutter <[email protected]> Reviewed-by: Tino Reichardt <[email protected]> Signed-off-by: Rob Norris <[email protected]> Closes #16479

Sponsored-by: https://despairlabs.com/sponsor/ Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Tony Hutter <[email protected]> Reviewed-by: Tino Reichardt <[email protected]> Signed-off-by: Rob Norris <[email protected]> Closes #16479

It always failed from "unused variable" warnings-errors. The resulting `#define page_mapping(...)` happend to work because it always overrode the kernel's function prototype, but that's brittle. Sponsored-by: https://despairlabs.com/sponsor/ Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Tony Hutter <[email protected]> Reviewed-by: Tino Reichardt <[email protected]> Signed-off-by: Rob Norris <[email protected]> Closes #16479

behlendorf · 2024-09-18T18:28:35Z

Merged thanks again for working through all of these config checks!

robn · 2024-09-19T01:55:22Z

Nice, thanks! And thanks everyone for the great feedback and testing. This will make things much easier going forward :)

Following 2b06976 (openzfs#16479), anything gated on a kernel version before 4.18 can be always included/excluded. Sponsored-by: https://despairlabs.com/sponsor/ Signed-off-by: Rob Norris <[email protected]>

Following 2b06976 (#16479), anything gated on a kernel version before 4.18 can be always included/excluded. Sponsored-by: https://despairlabs.com/sponsor/ Reviewed by: Brian Behlendorf <[email protected]> Reviewed-by: Alexander Motin <[email protected]> Reviewed-by: Tino Reichardt <[email protected]> Signed-off-by: Rob Norris <[email protected]> Closes #16545

Following 2b06976 (openzfs#16479), anything gated on a kernel version before 4.18 can be always included/excluded. Sponsored-by: https://despairlabs.com/sponsor/ Reviewed by: Brian Behlendorf <[email protected]> Reviewed-by: Alexander Motin <[email protected]> Reviewed-by: Tino Reichardt <[email protected]> Signed-off-by: Rob Norris <[email protected]> Closes openzfs#16545

robn mentioned this pull request Aug 26, 2024

Linux: bump minimum kernel version to 4.4 #16434

Closed

13 tasks

robn force-pushed the linux-min-4.18 branch from d9dce3c to 5dca474 Compare September 4, 2024 22:41

tonyhutter reviewed Sep 5, 2024

View reviewed changes

config/kernel-config-defined.m4 Show resolved Hide resolved

robn force-pushed the linux-min-4.18 branch from 5dca474 to dc705e8 Compare September 6, 2024 09:56

tonyhutter approved these changes Sep 10, 2024

View reviewed changes

amotin mentioned this pull request Sep 10, 2024

Direct IO Support #10018

Merged

17 tasks

mcmilk approved these changes Sep 15, 2024

View reviewed changes

robn force-pushed the linux-min-4.18 branch from dc705e8 to 9a73dcf Compare September 16, 2024 01:14

behlendorf added the Status: Code Review Needed Ready for review and testing label Sep 16, 2024

behlendorf approved these changes Sep 17, 2024

View reviewed changes

behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Sep 17, 2024

robn added 8 commits September 18, 2024 11:33

META: set Linux minimum version to 4.18

8304a0e

This sets RHEL8's base kernel[1] as the floor, and includes the oldest kernel.org LTS (4.19). 1. https://access.redhat.com/articles/3078#RHEL8 Sponsored-by: https://despairlabs.com/sponsor/ Signed-off-by: Rob Norris <[email protected]>

config: remove checks with unused defines

0be9702

All of these set a #define that doesn't appear anywhere in the tree. Sponsored-by: https://despairlabs.com/sponsor/ Signed-off-by: Rob Norris <[email protected]>

config: remove HAVE_1ARG_BIO_END_IO_T

3ba72e2

Sponsored-by: https://despairlabs.com/sponsor/ Signed-off-by: Rob Norris <[email protected]>

config: remove HAVE_BIO_BVEC_ITER

dd31672

Sponsored-by: https://despairlabs.com/sponsor/ Signed-off-by: Rob Norris <[email protected]>

config: remove HAVE_CLEAR_INODE and HAVE_EVICT_INODE

83dba29

Sponsored-by: https://despairlabs.com/sponsor/ Signed-off-by: Rob Norris <[email protected]>

config: remove HAVE_DENTRY_D_U_ALIASES

a950e94

Sponsored-by: https://despairlabs.com/sponsor/ Signed-off-by: Rob Norris <[email protected]>

config: remove HAVE_DIRTY_INODE_WITH_FLAGS

7fcbbdc

Sponsored-by: https://despairlabs.com/sponsor/ Signed-off-by: Rob Norris <[email protected]>

config: remove HAVE_D_MAKE_ROOT

5a52a81

Sponsored-by: https://despairlabs.com/sponsor/ Signed-off-by: Rob Norris <[email protected]>

robn mentioned this pull request Sep 19, 2024

Linux: remove code gated behind kernel version checks #16545

Closed

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Linux: bump minimum kernel version to 4.18 #16479

Linux: bump minimum kernel version to 4.18 #16479

robn commented Aug 26, 2024 •

edited

Loading

tonyhutter commented Sep 5, 2024

tonyhutter commented Sep 5, 2024

robn commented Sep 6, 2024

tonyhutter commented Sep 10, 2024

mcmilk left a comment

robn commented Sep 16, 2024 •

edited

Loading

behlendorf commented Sep 16, 2024

amotin commented Sep 16, 2024

mcmilk commented Sep 17, 2024

behlendorf commented Sep 17, 2024 •

edited

Loading

robn commented Sep 17, 2024

behlendorf commented Sep 18, 2024

robn commented Sep 19, 2024

Linux: bump minimum kernel version to 4.18 #16479

Linux: bump minimum kernel version to 4.18 #16479

Conversation

robn commented Aug 26, 2024 • edited Loading

Motivation and Context

Description

How Has This Been Tested?

Types of changes

Checklist:

tonyhutter commented Sep 5, 2024

tonyhutter commented Sep 5, 2024

robn commented Sep 6, 2024

tonyhutter commented Sep 10, 2024

mcmilk left a comment

Choose a reason for hiding this comment

robn commented Sep 16, 2024 • edited Loading

behlendorf commented Sep 16, 2024

amotin commented Sep 16, 2024

mcmilk commented Sep 17, 2024

behlendorf commented Sep 17, 2024 • edited Loading

robn commented Sep 17, 2024

behlendorf commented Sep 18, 2024

robn commented Sep 19, 2024

robn commented Aug 26, 2024 •

edited

Loading

robn commented Sep 16, 2024 •

edited

Loading

behlendorf commented Sep 17, 2024 •

edited

Loading