Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sa.c to build on FreeBSD again #16403

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

mcmilk
Copy link
Contributor

@mcmilk mcmilk commented Aug 1, 2024

Motivation and Context

OpenZFS master can not be build on FreeBSD currently.

Description

Fix multiple build errors on FreeBSD.

The main reason is, that the variable 'dxattr_obj' is used
uninitialized within the start of the 'out label'.

The goto out is used a lot before the variables get it's initialization.
But with right in the beginning of the out label there is an if (dxattr_obj) ....

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Fix multiple build errors on FreeBSD.

The main reason is, that the variable 'dxattr_obj' is used
uninitialized within the start of the 'out label'.

Signed-off-by: Tino Reichardt <[email protected]>
@mcmilk mcmilk changed the title Fix sa.c the build on FreeBSD again. Fix sa.c to build on FreeBSD again Aug 1, 2024
@tonyhutter tonyhutter merged commit c092bdd into openzfs:master Aug 1, 2024
21 of 23 checks passed
@mcmilk mcmilk deleted the fix-dxattr_obj branch August 24, 2024 13:53
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 4, 2024
Fix multiple build errors on FreeBSD.

The main reason is, that the variable 'dxattr_obj' is used
uninitialized within the start of the 'out label'.

Signed-off-by: Tino Reichardt <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants