Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple lines to the sharenfs property for FreeBSD #16338

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

rmacklem
Copy link
Contributor

There has been a bugzilla PR#147881 requesting this for a long time (14 years!). It extends the syntax of the ZFS shanenfs property (for FreeBSD only) to allow multiple sets of options for different hosts/nets, separated by ';'s.

Signed-off-by: Rick Macklem [email protected]

Motivation and Context

On FreeBSD, exports with separate sets of options can be provided for the
same file system for different hosts/subnets. A FreeBSD bugzilla PR to allow ZFS's sharenfs
property to do this has existed for 14years.

Description

Allows multiple sets of export options to be expressed in the sharenfs property
separated by semicolons. Each set generates a line in /etc/zfs/exports.
The patch also replaces the use of arrays of size OPTSSIZE with malloc'd arrays
to hold the option lists. This change was suggested by [email protected].

How Has This Been Tested?

A variety of settings for the sharenfs property, with and without semicolons in
it were tried on FreeBSD and the resultant /etc/zfs/exports was checked for
correctness.

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • [x ] Documentation (a change to man pages or other documentation)

Checklist:

  • [x ] My code follows the OpenZFS code style requirements.
  • [x ] I have updated the documentation accordingly.
  • [x ] I have read the contributing document.
  • I have added tests to cover my changes.
  • [x ] I have run the ZFS Test Suite with this change applied.
  • [x ] All commit messages are properly formatted and contain Signed-off-by.

man/man7/zfsprops.7 Outdated Show resolved Hide resolved
There has been a bugzilla PR#147881 requesting this
for a long time (14 years!). It extends the syntax of
the ZFS shanenfs property (for FreeBSD only) to allow
multiple sets of options for different hosts/nets,
separated by ';'s.

Signed-off-by:	Rick Macklem <[email protected]>
@tonyhutter tonyhutter merged commit dbe0792 into openzfs:master Jul 23, 2024
23 of 25 checks passed
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 4, 2024
…penzfs#16338)

There has been a bugzilla PR#147881 requesting this
for a long time (14 years!). It extends the syntax of
the ZFS shanenfs property (for FreeBSD only) to allow
multiple sets of options for different hosts/nets,
separated by ';'s.

Signed-off-by:	Rick Macklem <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tino Reichardt <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants