Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverity model should know that KM_NOSLEEP means no sleeping #16263

Closed
wants to merge 1 commit into from

Conversation

ryao
Copy link
Contributor

@ryao ryao commented Jun 13, 2024

Motivation and Context

This fixes an old oversight. I doubt it affected the accuracy of coverity very much, but it is an improvement that I caught while discussing the latest coverity results with Rob N.

Description

The model is updated to only consider sleeping when KM_NOSLEEP is not used. Previously, it always assumed sleeping was possible. Coverity has some checks that can detect issues when sleeping is done, although it is very rare, so it is unlikely this affected us.

How Has This Been Tested?

The new model file will be uploaded to coverity shortly. We will know if it causes anything to go haywire soon afterward, but that is highly unlikely.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@robn
Copy link
Member

robn commented Jun 13, 2024

I think the same change needs to be made to the vmem variants.

This fixes an old oversight. I doubt it affected the accuracy of
coverity very much, but it is an improvement that I caught while
discussing the latest coverity results with Rob N.

Signed-off-by: Richard Yao <[email protected]>
@ryao
Copy link
Contributor Author

ryao commented Jun 14, 2024

I think the same change needs to be made to the vmem variants.

Done.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Jun 14, 2024
@ryao
Copy link
Contributor Author

ryao commented Jun 15, 2024

I am withdrawing this, as while it is technically correct, a regression in Coverity causes the models being touched by this to be broken both with and without this, so there is no point in doing things the correct way. I might include this as part of a different PR including the fix for the major issue in Coverity, but it would be purely a documentation matter in that case.

@ryao ryao closed this Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Code Review Needed Ready for review and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants