disable automatic dependency tracking for dkms builds #16241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the dkms build left some unwanted files in `/usr/lib/modules` which could cause package managers to not properly clean up old kernels. Signed-off-by: Martin Wagner <[email protected]>
|
Nice, this may speed up dkms builds as well:
https://www.gnu.org/software/automake/manual/html_node/Dependency-Tracking.html |
tonyhutter
approved these changes
Jun 14, 2024
behlendorf
approved these changes
Jun 14, 2024
behlendorf
added
Status: Accepted
robn
pushed a commit
to robn/zfs
that referenced
this pull request
Jul 18, 2024
Previously the dkms build left some unwanted files in `/usr/lib/modules` which could cause package managers to not properly clean up old kernels. Reviewed-by: Tony Hutter <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Martin Wagner <[email protected]> Closes openzfs#16221 Closes openzfs#16241
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Sep 4, 2024
Previously the dkms build left some unwanted files in `/usr/lib/modules` which could cause package managers to not properly clean up old kernels. Reviewed-by: Tony Hutter <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Martin Wagner <[email protected]> Closes openzfs#16221 Closes openzfs#16241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This should fix #16221.
Description
This PR simply disables automatic dependency tracking for the dkms build. Maybe it could be disabled in
configure.acdirectly but I don't know if there a any drawbacks.How Has This Been Tested?
I've adjusted the
dkms.conflocally and can confirm that this fixed the issue.Types of changes
Checklist:
Signed-off-by.