Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zfs get: add '-t fs' and '-t vol' options #16117

Merged
merged 1 commit into from
Apr 22, 2024
Merged

zfs get: add '-t fs' and '-t vol' options #16117

merged 1 commit into from
Apr 22, 2024

Conversation

ErrorNoInternet
Copy link
Contributor

Motivation and Context

Because zfs get -t filesystem is also too long :)

Description

Make zfs get -t accept fs for filesystem and vol for volume.

How Has This Been Tested?

Manually, with

$ zfs get -t fs compression
NAME                    PROPERTY     VALUE           SOURCE
...

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@ErrorNoInternet
zfs get: add '-t fs' and '-t vol' options
5db0370 
Make `zfs get` accept `fs` for `filesystem` and `vol` for `volume`.

Signed-off-by: Ryan <[email protected]>
robn
robn approved these changes Apr 20, 2024
View reviewed changes
Copy link
Member

@robn robn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly amused to find that people actually read my rubbish lol

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Apr 22, 2024
@behlendorf behlendorf merged commit c346068 into openzfs:master Apr 22, 2024
24 of 25 checks passed
@ErrorNoInternet ErrorNoInternet deleted the zfs-get-fs-vol branch April 24, 2024 09:59
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 4, 2024
@ErrorNoInternet @lundman
zfs get: add '-t fs' and '-t vol' options
074b8ea 
Make `zfs get` accept `fs` for `filesystem` and `vol` for `volume`.

Reviewed-by: Rob Norris <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Ryan <[email protected]>
Closes openzfs#16117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robn robn robn approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ErrorNoInternet @robn @behlendorf