config/Substfiles.am: restrict to the dedicated list. #15980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could be considered together with #15979. |
behlendorf
reviewed
Apr 4, 2024
|
@heroxbd if you can rebase this change on master and force update the PR we can get it included. |
We recover the scope of $(SUBSTFILES) to explicitly control what files are being generated from the corresponding .in. Signed-off-by: Benda Xu <[email protected]>
behlendorf
approved these changes
Apr 9, 2024
behlendorf
added
Status: Accepted
|
Thanks Brian! |
tonyhutter
pushed a commit
that referenced
this pull request
May 2, 2024
We recover the scope of $(SUBSTFILES) to explicitly control what files are being generated from the corresponding .in. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Benda Xu <[email protected]> Closes #15980
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Sep 4, 2024
We recover the scope of $(SUBSTFILES) to explicitly control what files are being generated from the corresponding .in. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Benda Xu <[email protected]> Closes openzfs#15980
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We recover the scope of $(SUBSTFILES) to explicitly control what files are being generated from the corresponding .in.
Description
Put zfs_prepare_disk.8 into substitution list. b53077a forgot to include the zfs_prepare_disk.8 in the substitution list, although it built in the past because 38e2e9c accidentally dropped the $(SUBSTFILES) from the "%: %.in" pattern.
How Has This Been Tested?
Tested in Debian unstable.
Types of changes
Checklist:
Signed-off-by.