Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vdev props comment and manpage should include zfsd and FreeBSD mentions #15968

Merged
merged 1 commit into from
Apr 4, 2024
Merged

vdev props comment and manpage should include zfsd and FreeBSD mentions #15968

merged 1 commit into from
Apr 4, 2024

Conversation

alek-p
Copy link
Contributor

@alek-p alek-p commented Mar 6, 2024

After merging https://reviews.freebsd.org/D44043 there are a couple of loose ends to tie up.

Motivation and Context

https://reviews.freebsd.org/D44043 introduces vdev prop retire/degrade threshold support for FreeBSD's zfsd.
This means we now have the same tunables for Linux and FreeBSD device retirement/degrading settings.

Description

The default settings for Linux are different from FreeBSD so the defaults description in vdevprops.7 could have confused people.

How Has This Been Tested?

I've run the zfsd test suite on FreeBSD.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

allanjude
allanjude approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@allanjude allanjude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-by: Allan Jude <[email protected]>

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Apr 4, 2024
@behlendorf behlendorf merged commit ea2862c into openzfs:master Apr 4, 2024
25 of 26 checks passed
@alek-p alek-p deleted the D44043 branch April 4, 2024 17:04
tonyhutter pushed a commit that referenced this pull request May 2, 2024
@alek-p @tonyhutter
vdev props comment and manpage should include zfsd and FreeBSD mentions
74101f7 
Reviewed-by: Tino Reichardt <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Rob Norris <[email protected]>
Reviewed-by: Allan Jude <[email protected]>
Signed-off-by: Alek Pinchuk <[email protected]>
Closes #15968
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 4, 2024
@alek-p @lundman
vdev props comment and manpage should include zfsd and FreeBSD mentions
8cc9791 
Reviewed-by: Tino Reichardt <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Reviewed-by: Tony Hutter <[email protected]>
Reviewed-by: Rob Norris <[email protected]>
Reviewed-by: Allan Jude <[email protected]>
Signed-off-by: Alek Pinchuk <[email protected]>
Closes openzfs#15968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robn robn robn approved these changes

@allanjude allanjude allanjude approved these changes

@mcmilk mcmilk mcmilk approved these changes

@amotin amotin amotin approved these changes

@tonyhutter tonyhutter tonyhutter approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alek-p @robn @allanjude @mcmilk @amotin @tonyhutter @behlendorf