Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing PERFPOOL to be defined by zfs-test users #15868

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

kxgreene
Copy link
Contributor

@kxgreene kxgreene commented Feb 8, 2024

Motivation and Context

When using the performance tests in zfs-test, the pool chosen is hardcoded to perfpool.

It would be beneficial for users to be able to choose the name of their pool. One example is if
the user has ongoing monitoring on a pool name (say domain0), they would be able to
monitor their pool during performance testing by passing in domain0 in an environment
variable.

Description

Allows the PERFPOOL variable to be collected from an environment variable.

How Has This Been Tested?

I have run zfs-tests with a pool name assigned and saw the zpool create commands
create the correctly named zpool.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf merged commit 79c6dff into openzfs:master Feb 9, 2024
22 of 23 checks passed
@kxgreene kxgreene deleted the perfpool branch February 9, 2024 20:07
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Mar 13, 2024
Reviewed-by: John Wren Kennedy <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Kevin Greene <[email protected]>
Closes openzfs#15868
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Mar 13, 2024
Reviewed-by: John Wren Kennedy <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Kevin Greene <[email protected]>
Closes openzfs#15868
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Mar 13, 2024
Reviewed-by: John Wren Kennedy <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Kevin Greene <[email protected]>
Closes openzfs#15868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants