-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to man pages for zpool-iostat, zpool-list, zpool-status and zpool-wait to resolve time(2) -> time(1) #15823
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change itself looks fine can you just resolve the two style warnings and force update the PR.
https://github.com/openzfs/zfs/actions/runs/7661248838/job/20880232317?pr=15823
error: commit subject over 72 characters
error: missing "Signed-off-by"
zpool-iostat.8: Updated time(2) -> time(1) to align to manual page zpool-list.8: Updated time(2) -> time(1) to align to manual page zpool-status.8: Updated time(2) -> time(1) to align to manual page zpool-wait.8: Update time(2) -> time(1) to align to manual page Signed-off-by: Christopher Davidson <[email protected]>
Thank you for the review comments and recommendations. Both of these should be resolved now and captured in the subsequent commit associated with this PR. |
zpool-iostat.8: Updated time(2) -> time(1) to align to manual page zpool-list.8: Updated time(2) -> time(1) to align to manual page zpool-status.8: Updated time(2) -> time(1) to align to manual page zpool-wait.8: Update time(2) -> time(1) to align to manual page Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Christopher Davidson <[email protected]> Closes openzfs#15823
zpool-iostat.8: Updated time(2) -> time(1) to align to manual page zpool-list.8: Updated time(2) -> time(1) to align to manual page zpool-status.8: Updated time(2) -> time(1) to align to manual page zpool-wait.8: Update time(2) -> time(1) to align to manual page Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Christopher Davidson <[email protected]> Closes #15823
zpool-iostat.8: Updated time(2) -> time(1) to align to manual page zpool-list.8: Updated time(2) -> time(1) to align to manual page zpool-status.8: Updated time(2) -> time(1) to align to manual page zpool-wait.8: Update time(2) -> time(1) to align to manual page Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Christopher Davidson <[email protected]> Closes openzfs#15823
zpool-iostat.8: Updated time(2) -> time(1) to align to manual page zpool-list.8: Updated time(2) -> time(1) to align to manual page zpool-status.8: Updated time(2) -> time(1) to align to manual page zpool-wait.8: Update time(2) -> time(1) to align to manual page Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Christopher Davidson <[email protected]> Closes openzfs#15823
zpool-iostat.8: Updated time(2) -> time(1) to align to manual page
zpool-list.8: Updated time(2) -> time(1) to align to manual page
zpool-status.8: Updated time(2) -> time(1) to align to manual page
zpool-wait.8: Update time(2) -> time(1) to align to manual page
Signed-off-by: Christopher Davidson [email protected]
Motivation and Context
This change was applied to the manual pages to resolve misaligned .Xr references in the manual pages as they were in FreeBSD-CURRENT.
Description
The manual pages were confirmed to be aligned to time(2) and double checked with a few spots checks:
How Has This Been Tested?
The testing conducted was spot check with the above items and checking multiple releases of FreeBSD: FreeBSD 14.0 (amd64) FreeBSD(arm - raspberry pi) FreeBSD-CURRENT (amd64) and all confirmed same result.
Types of changes
Checklist:
Signed-off-by
.