Sync AUX label on import

[ixhamza]

Spare and l2cache vdev labels are not updated during import. Therefore, if disk paths are updated between pool export and import, the AUX label still shows the old paths. This patch syncs the AUX label during import to show the correct path information.

How Has This Been Tested?

Made changes to disk paths between pool export and import, and verified that the latest AUX labels are correctly shown by zdb:

# Added spare with devid: driveOld
root@ub22:~# zpool create tank mirror sdb sdc spare sdd -f

root@ub22:~# zdb -l /dev/sdd1
------------------------------------
LABEL 0 
------------------------------------
    version: 5000
    state: 3
    guid: 4218101932799396375
    path: '/dev/sdd1'
    devid: 'scsi-0QEMU_QEMU_HARDDISK_driveOld-part1'
    phys_path: 'pci-0000:00:05.0-scsi-0:0:0:0'
    labels = 0 1 2 3 

root@ub22:~# zpool export tank

# Change devid to driveNew
root@ub22:~# zpool import tank

root@ub22:~# zdb -l /dev/sdd1
------------------------------------
LABEL 0 
------------------------------------
    version: 5000
    state: 3
    guid: 4218101932799396375
    path: '/dev/sdd1'
    devid: 'scsi-0QEMU_QEMU_HARDDISK_driveNew-part1'
    phys_path: 'pci-0000:00:05.0-scsi-0:0:0:0'
    labels = 0 1 2 3

# Without this patch, zdb does not show updated devid

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
• Documentation (a change to man pages or other documentation)

Checklist:

• My code follows the OpenZFS code style requirements.
• I have updated the documentation accordingly.
• I have read the contributing document.
• I have added tests to cover my changes.
• I have run the ZFS Test Suite with this change applied.
• All commit messages are properly formatted and contain Signed-off-by.

[ixhamza]

zfs-linux / functional (part2) appears to be failing on CI. Will check what is the issue.

[ixhamza]

The updated commit resolves the CI test failures that were occurring due to this patch. Additionally, it has been rebased with the master. Some 20.04 tests are failing, but they are unrelated to this patch. For example, similar failures can be seen on other PR as well: zfs-2.2.3 patchset Actions. These failures on the recent PRs appear to be persistent whenever the 20.04 tests are run on the 20240218.1.0 image runner.

[ixhamza]

@tonyhutter - It would be nice if you could take a look at this PR. I just rebased it with the latest master today.

[tonyhutter]

Looks like everything is passing except Centos 8:

Tests with results other than PASS that are unexpected:
    FAIL cli_root/zpool_trim/zpool_trim_fault_export_import_online (expected PASS)
    FAIL fault/auto_online_002_pos (expected PASS)
    FAIL fault/auto_spare_shared (expected PASS)
    FAIL mmp/mmp_exported_import (expected PASS)
    FAIL mmp/mmp_inactive_import (expected PASS)

I'm going to manually re-run that test to make sure it's not a red herring.

[ixhamza]

Rebased with the master branch for CI rerun.

[behlendorf]

Looks good. I'll get this merged once the CI finishes with it. Thanks for updating this and sorry about the delay.