-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZTS: Apply small changes for speeding up the tests #15811
Conversation
Do you have any performance comparisons for this change? |
Since last week, the runner hardware improved a lot. This is the comparison for a freshly created runner:
|
# -> we reformat with ext4 + move it to /var/tmp | ||
DEV="/dev/disk/azure/resource-part1" | ||
sudo umount /mnt | ||
sudo mkfs.ext4 -F $DEV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we already format and remount ext4 - maybe:
- mount with
noatime,barrier=0
? - disable journal?
- maybe compilation will be faster too from this ssd? If it's so - we may move code onto it
- other speedups I've missed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mount with noatime,barrier=0 ?
disable journal?
These two are done .... thanks for pointing out.
maybe compilation will be faster too from this ssd? If it's so - we may move code onto it
Compiling is done once on startup in ~10..20 minutes. This should be okay.
The Github Action Runner got some new hardware metrics. We should use the provided and empty disk which is pre-mounted at /mnt now. Disk1: 89GiB -> rootfs + bootfs with ~80MB/s -> don't care Disk2: 64GiB -> /mnt with 420MB/s -> new testing ssd This commit will mount the new disk to /var/tmp and provide hopefully some speedups within our testings. Signed-off-by: Tino Reichardt <[email protected]>
The Github Action Runner got some new hardware metrics. We should use the provided and empty disk which is pre-mounted at /mnt now. Disk1: 89GiB -> rootfs + bootfs with ~80MB/s -> don't care Disk2: 64GiB -> /mnt with 420MB/s -> new testing ssd This commit will mount the new disk to /var/tmp and provide hopefully some speedups within our testings. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: George Melikov <[email protected]> Reviewed-by: Andrew Innes <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#15811
The Github Action Runner got some new hardware metrics. We should use the provided and empty disk which is pre-mounted at /mnt now. Disk1: 89GiB -> rootfs + bootfs with ~80MB/s -> don't care Disk2: 64GiB -> /mnt with 420MB/s -> new testing ssd This commit will mount the new disk to /var/tmp and provide hopefully some speedups within our testings. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: George Melikov <[email protected]> Reviewed-by: Andrew Innes <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes #15811
I've noticed sporadic test failures in the code added in this PR; I'm not sure if it's a bug that's always been there, or if something has changed with the github workers, but a nontrivial number of test runs are failing as a result. |
I noticed these I am in doubt if the other disk space is the reason for that - but we could test this, by reverting this PR maybe... |
The Github Action Runner got some new hardware metrics. We should use the provided and empty disk which is pre-mounted at /mnt now. Disk1: 89GiB -> rootfs + bootfs with ~80MB/s -> don't care Disk2: 64GiB -> /mnt with 420MB/s -> new testing ssd This commit will mount the new disk to /var/tmp and provide hopefully some speedups within our testings. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: George Melikov <[email protected]> Reviewed-by: Andrew Innes <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#15811
The Github Action Runner got some new hardware metrics. We should use the provided and empty disk which is pre-mounted at /mnt now. Disk1: 89GiB -> rootfs + bootfs with ~80MB/s -> don't care Disk2: 64GiB -> /mnt with 420MB/s -> new testing ssd This commit will mount the new disk to /var/tmp and provide hopefully some speedups within our testings. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: George Melikov <[email protected]> Reviewed-by: Andrew Innes <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#15811
Motivation and Context
The Github Action Runner got some new hardware metrics.
We should use the provided and empty disk which is pre-mounted at /mnt now.
Disk1: 89GiB -> rootfs + bootfs with ~80MB/s -> don't care
Disk2: 64GiB -> /mnt with 420MB/s -> new testing ssd
Description
This commit will mount the new disk to /var/tmp and provide hopefully some speedups within our testings.
How Has This Been Tested?
We will see, how much seepup we can get... when the ZTS is done with it ;-)
Types of changes
Checklist:
Signed-off-by
.