libnvpair.c: replace strstr() with strchr() for a single character #15798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're looking for a single new-line character in the haystack, it's better (and slightly efficient) to use strchr() instead of strstr(). Signed-off-by: rilysh <[email protected]>
ryao
approved these changes
Jan 21, 2024
behlendorf
approved these changes
Jan 23, 2024
behlendorf
added
Status: Code Review Needed
|
Commit message line length fixes when merging. |
|
Oh whoops, I forgot about this PR... sorry for the late reply, glad to know it automatically fixed! |
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Mar 13, 2024
Since we're looking for a single new-line character in the haystack, it's better (and slightly more efficient) to use strchr() instead of strstr(). Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Richard Yao <[email protected]> Signed-off-by: rilysh <[email protected]> Closes openzfs#15798
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Mar 13, 2024
Since we're looking for a single new-line character in the haystack, it's better (and slightly more efficient) to use strchr() instead of strstr(). Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Richard Yao <[email protected]> Signed-off-by: rilysh <[email protected]> Closes openzfs#15798
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR creates changes in libnvpair.c, where it replaces strstr() with strchr(). Generally, compilers (such as GCC/Clang) can replace these strstr() calls with strchr() in compile time, if it finds that it only searches for a single character, but since it's too obvious and noticeable, source change seems a good idea.
Types of changes
Checklist:
Signed-off-by.