Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.2] zfs_setattr: fix atime update #15774

Merged
merged 1 commit into from
Jan 17, 2024
Merged

[2.2] zfs_setattr: fix atime update #15774

merged 1 commit into from
Jan 17, 2024

Commits on Jan 16, 2024

  1. Linux 6.7 compat: zfs_setattr fix atime update 

    In db4fc55 I messed up and changed this bit of code to set the inode
atime to an uninitialised value, when actually it was just supposed to
loading the atime from the inode to be stored in the SA. This changes it
to what it should have been.

Ensure times change by the right amount Previously, we only checked
if the times changed at all, which missed a bug where the atime was
being set to an undefined value.

Now ensure the times change by two seconds (or thereabouts), ensuring
we catch cases where we set the time to something bonkers

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Rob Norris <[email protected]>
Sponsored-by: https://despairlabs.com/sponsor/
Closes openzfs#15762
Closes openzfs#15773
    @robn
    robn committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    4736ff4 View commit details
    Browse the repository at this point in the history