Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop wasting time on malloc in snprintf_zstd_header #15721

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Stop wasting time on malloc in snprintf_zstd_header #15721

merged 1 commit into from
Jan 12, 2024

Commits on Dec 30, 2023

  1. Stop wasting time on malloc in snprintf_zstd_header 

    Profiling zdb -vvvvv on datasets with a lot of zstd blocks, we find
ourselves spending quite a lot of time on malloc/free, because we
allocate a 16M abd each call, and never free it, so we're leaking
16M per call as well.

This seems sub-optimal. So let's just keep the buffer around and
reuse it.

Signed-off-by: Rich Ercolani <[email protected]>
    @rincebrain
    rincebrain committed Dec 30, 2023
    Configuration menu
    Copy the full SHA
    a00d7d4 View commit details
    Browse the repository at this point in the history