Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux 6.5 compat: check BLK_OPEN_EXCL is defined #15692

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Linux 6.5 compat: check BLK_OPEN_EXCL is defined #15692

merged 1 commit into from
Dec 21, 2023

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

See #15099 (comment)

Description

This is an alternate fix to #15688 which instead leverages an existing mechanism to check for the right flags.

How Has This Been Tested?

Locally compiled.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf
Linux 6.5 compat: check BLK_OPEN_EXCL is defined
eeb3939 
On some systems we already have blkdev_get_by_path() with 4 args
but still the old FMODE_EXCL and not BLK_OPEN_EXCL defined.
The vdev_bdev_mode() function was added to handle this case
but there was no generic way to specify exclusive access.

Signed-off-by: Brian Behlendorf <[email protected]>
@behlendorf behlendorf added Type: Building Indicates an issue related to building binaries Status: Code Review Needed Ready for review and testing labels Dec 20, 2023
@behlendorf behlendorf mentioned this pull request Dec 20, 2023
Closed
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 21, 2023
@behlendorf behlendorf merged commit 233d34e into openzfs:master Dec 21, 2023
22 of 25 checks passed
behlendorf added a commit to behlendorf/zfs that referenced this pull request Dec 21, 2023
@behlendorf
Linux 6.5 compat: check BLK_OPEN_EXCL is defined
9ee0337 
On some systems we already have blkdev_get_by_path() with 4 args
but still the old FMODE_EXCL and not BLK_OPEN_EXCL defined.
The vdev_bdev_mode() function was added to handle this case
but there was no generic way to specify exclusive access.

Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#15692
@behlendorf behlendorf mentioned this pull request Dec 21, 2023
Merged
13 tasks
behlendorf added a commit that referenced this pull request Dec 22, 2023
@behlendorf
Linux 6.5 compat: check BLK_OPEN_EXCL is defined
d530d5d 
On some systems we already have blkdev_get_by_path() with 4 args
but still the old FMODE_EXCL and not BLK_OPEN_EXCL defined.
The vdev_bdev_mode() function was added to handle this case
but there was no generic way to specify exclusive access.

Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes #15692
robn pushed a commit to robn/zfs that referenced this pull request Feb 7, 2024
@behlendorf @robn
Linux 6.5 compat: check BLK_OPEN_EXCL is defined
d094732 
On some systems we already have blkdev_get_by_path() with 4 args
but still the old FMODE_EXCL and not BLK_OPEN_EXCL defined.
The vdev_bdev_mode() function was added to handle this case
but there was no generic way to specify exclusive access.

Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#15692
(cherry picked from commit d530d5d)
@robn robn mentioned this pull request Feb 7, 2024
Merged
13 tasks
tonyhutter pushed a commit that referenced this pull request Feb 8, 2024
@behlendorf @tonyhutter
Linux 6.5 compat: check BLK_OPEN_EXCL is defined
a9dc116 
On some systems we already have blkdev_get_by_path() with 4 args
but still the old FMODE_EXCL and not BLK_OPEN_EXCL defined.
The vdev_bdev_mode() function was added to handle this case
but there was no generic way to specify exclusive access.

Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes #15692
(cherry picked from commit d530d5d)
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Mar 13, 2024
@behlendorf @lundman
Linux 6.5 compat: check BLK_OPEN_EXCL is defined
71fffba 
On some systems we already have blkdev_get_by_path() with 4 args
but still the old FMODE_EXCL and not BLK_OPEN_EXCL defined.
The vdev_bdev_mode() function was added to handle this case
but there was no generic way to specify exclusive access.

Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#15692
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Mar 13, 2024
@behlendorf @lundman
Linux 6.5 compat: check BLK_OPEN_EXCL is defined
bf6cc40 
On some systems we already have blkdev_get_by_path() with 4 args
but still the old FMODE_EXCL and not BLK_OPEN_EXCL defined.
The vdev_bdev_mode() function was added to handle this case
but there was no generic way to specify exclusive access.

Reviewed-by: Brian Atkinson <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#15692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwatkinson bwatkinson bwatkinson approved these changes

@tonyhutter tonyhutter Awaiting requested review from tonyhutter

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested) Type: Building Indicates an issue related to building binaries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@behlendorf @bwatkinson