Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.1.15] Report ashift of L2ARC devices in zdb #15690

Merged
merged 1 commit into from
Dec 21, 2023
Merged

[2.1.15] Report ashift of L2ARC devices in zdb #15690

merged 1 commit into from
Dec 21, 2023

Conversation

gamanakis
Copy link
Contributor

@gamanakis gamanakis commented Dec 20, 2023 •
edited
Loading

Backport fe4d055 in 2.1.15

Upstream commit:
Commit 8af1104 does not actually store the ashift of cache devices in their label. However, in order to facilitate reporting the ashift through zdb, we enable this in the present commit. We also document how the retrieval of the ashift is done.

Reviewed-by: Brian Behlendorf [email protected]
Signed-off-by: George Amanakis [email protected]
Closes #15331

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@gamanakis
Report ashift of L2ARC devices in zdb
11c86dc 
Commit 8af1104 does not actually store the ashift of cache devices in
their label. However, in order to facilitate reporting the ashift
through zdb, we enable this in the present commit. We also document
how the retrieval of the ashift is done.

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: George Amanakis <[email protected]>
Closes openzfs#15331
@gamanakis gamanakis changed the title Report ashift of L2ARC devices in zdb [2.1.15] Report ashift of L2ARC devices in zdb Dec 20, 2023
@gamanakis gamanakis mentioned this pull request Dec 20, 2023
Closed
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Dec 20, 2023
@behlendorf behlendorf merged commit e1bc32f into openzfs:zfs-2.1.15-staging Dec 21, 2023
6 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gamanakis @behlendorf