Block cloning tests. #15631
Block cloning tests. #15631
Conversation
|
This is great @pjd, thanks. If no one else gets in I'll try to take a good look through over the weekend.
Is there a useful subset that we could put on the common or sanity lists? |
There was a problem hiding this comment.
@pjd it's great to see these additional comprehensive tests. If you'd like to test them independently in the CI you could additionally create a bclone.run file and then tweak the top level TESTS files like this. That would let us get them running, see how long they take in the CI environment, and maybe let us pick a subset to run regularly.
-#TEST_ZFSTESTS_RUNFILE="linux.run"
+TEST_ZFSTESTS_RUNFILE="bclone.run"
| - If dedup enabled, block_cloning uses dedup. | ||
| - block_cloning works only with the same encryption key | ||
| - check when block cloning doesn't suppose to work | ||
| - check block cloning between two different pools | ||
| - test with sync=always,default,disabled | ||
| - block cloning from a snapshot |
There was a problem hiding this comment.
nice work, maybe have time at the weekend as well.
don't know but is it important to rebase this, because of some new commit in the master? diff there is across encrypted devices new for example
There was a problem hiding this comment.
Also some tests are added for encrypted datasets.
pjd
force-pushed
the
brt-tests
branch
6 times, most recently
from
edb220f
to
11b7fee
Compare
Yes, I've added all short tests to common.run plus 100 randomly selected at each run corner case tests. |
pjd
force-pushed
the
brt-tests
branch
2 times, most recently
from
51cef8e
to
dc92915
Compare
pjd
force-pushed
the
brt-tests
branch
3 times, most recently
from
6b34d27
to
de8c653
Compare
The test mostly focus on testing various corner cases. The tests take a long time to run, so for the common.run runfile we randomly select a hundred tests. To run all the bclone tests, bclone.run runfile should be used. Signed-off-by: Pawel Jakub Dawidek <[email protected]>
behlendorf
added
Status: Accepted
The test mostly focus on testing various corner cases. The tests take a long time to run, so for the common.run runfile we randomly select a hundred tests. To run all the bclone tests, bclone.run runfile should be used. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Pawel Jakub Dawidek <[email protected]> Closes openzfs#15631
The test mostly focus on testing various corner cases. The tests take a long time to run, so for the common.run runfile we randomly select a hundred tests. To run all the bclone tests, bclone.run runfile should be used. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Pawel Jakub Dawidek <[email protected]> Closes openzfs#15631
The test mostly focus on testing various corner cases. The tests take a long time to run, so for the common.run runfile we randomly select a hundred tests. To run all the bclone tests, bclone.run runfile should be used. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Pawel Jakub Dawidek <[email protected]> Closes openzfs#15631
The test mostly focus on testing various corner cases. The tests take a long time to run, so for the common.run runfile we randomly select a hundred tests. To run all the bclone tests, bclone.run runfile should be used. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Pawel Jakub Dawidek <[email protected]> Closes #15631
The test mostly focus on testing various corner cases. The tests take a long time to run, so for the common.run runfile we randomly select a hundred tests. To run all the bclone tests, bclone.run runfile should be used. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Pawel Jakub Dawidek <[email protected]> Closes openzfs#15631
The test mostly focus on testing various corner cases. The tests take a long time to run, so for the common.run runfile we randomly select a hundred tests. To run all the bclone tests, bclone.run runfile should be used. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Pawel Jakub Dawidek <[email protected]> Closes openzfs#15631
Mostly focusing on testing various corner cases.
Motivation and Context
There are a lot of corner cases related to block cloning that have to be handled in the kernel.
Those additional tests try to exercise as many of those corner cases as possible.
Description
The new tests take a long time to execute (~5h), so they can be executed through a dedicated runfile - bclone.run.
In common.run runfile there are all the tests, except for the corner case tests - for those only 100 randomly selected tests will be executed.
How Has This Been Tested?
The tests pass on FreeBSD and Linux.
Types of changes
Checklist:
Signed-off-by.