Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZTS: Add Test Case for Block Cloning Replay #15614

Closed
wants to merge 2 commits into from
Closed

ZTS: Add Test Case for Block Cloning Replay #15614

wants to merge 2 commits into from

Conversation

ixhamza
Copy link
Contributor

@ixhamza ixhamza commented Nov 30, 2023 •
edited
Loading

This PR adds two tests (with and without encrypted datasets) when the cloned file is replayed through ZIL. block_cloning_replay_encrypted specfically validates the scenario that @amotin fixed under 27d8c23.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Dec 1, 2023
oromenahar
oromenahar suggested changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@oromenahar oromenahar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch and good idea to test this.

@ixhamza
Copy link
Contributor Author

ixhamza commented Dec 6, 2023

Updated as per feedback. Please note that added tests will be failing until #15634 is merged.

@behlendorf
Copy link
Contributor

#15634 has been merged when you get a moment to rebase this.

behlendorf
behlendorf reviewed Dec 7, 2023
View reviewed changes
tests/runfiles/linux.run Outdated Show resolved Hide resolved
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 7, 2023
@behlendorf behlendorf closed this in 5ff4396 Dec 9, 2023
behlendorf pushed a commit that referenced this pull request Dec 9, 2023
@ixhamza @behlendorf
ZTS: Add test cases for block cloning replay
2ebb9a4 
Reviewed-by: Kay Pedersen <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by:  Alexander Motin <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Closes #15614
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Dec 12, 2023
@ixhamza @lundman
ZTS: block_cloning: Use numeric sort for get_same_blocks
0491825 
Reviewed-by: Kay Pedersen <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by:  Alexander Motin <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Closes openzfs#15614
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Dec 12, 2023
@ixhamza @lundman
ZTS: Add test cases for block cloning replay
4c6a820 
Reviewed-by: Kay Pedersen <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by:  Alexander Motin <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Closes openzfs#15614
mmatuska pushed a commit to mmatuska/zfs that referenced this pull request Jan 17, 2024
@ixhamza @mmatuska
ZTS: Add test cases for block cloning replay
27cf2de 
Reviewed-by: Kay Pedersen <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by:  Alexander Motin <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Closes openzfs#15614
@mmatuska mmatuska mentioned this pull request Jan 17, 2024
Merged
13 tasks
mmatuska pushed a commit to mmatuska/zfs that referenced this pull request Jan 18, 2024
@ixhamza @mmatuska
ZTS: block_cloning: Use numeric sort for get_same_blocks
a876b3c 
Reviewed-by: Kay Pedersen <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by:  Alexander Motin <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Closes openzfs#15614
mmatuska pushed a commit to mmatuska/zfs that referenced this pull request Jan 18, 2024
@ixhamza @mmatuska
ZTS: Add test cases for block cloning replay
6a82e52 
Reviewed-by: Kay Pedersen <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by:  Alexander Motin <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Closes openzfs#15614
mmatuska pushed a commit to mmatuska/zfs that referenced this pull request Jan 18, 2024
@ixhamza @mmatuska
ZTS: block_cloning: Use numeric sort for get_same_blocks
a2016bc 
Reviewed-by: Kay Pedersen <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by:  Alexander Motin <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Closes openzfs#15614
mmatuska pushed a commit to mmatuska/zfs that referenced this pull request Jan 18, 2024
@ixhamza @mmatuska
ZTS: Add test cases for block cloning replay
c1bd2ba 
Reviewed-by: Kay Pedersen <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by:  Alexander Motin <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Closes openzfs#15614
behlendorf pushed a commit that referenced this pull request Jan 19, 2024
@ixhamza @behlendorf
ZTS: block_cloning: Use numeric sort for get_same_blocks
387f003 
Reviewed-by: Kay Pedersen <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by:  Alexander Motin <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Closes #15614
behlendorf pushed a commit that referenced this pull request Jan 19, 2024
@ixhamza @behlendorf
ZTS: Add test cases for block cloning replay
d8b0b60 
Reviewed-by: Kay Pedersen <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by:  Alexander Motin <[email protected]>
Signed-off-by: Ameer Hamza <[email protected]>
Closes #15614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@amotin amotin amotin left review comments

@oromenahar oromenahar oromenahar approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ixhamza @behlendorf @amotin @oromenahar