-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused variants of Skein #14708
base: master
Are you sure you want to change the base?
Conversation
It builds on my big-endian POWER7 machine, with Linux 4.1 and 6.1. No further testings are done because current running kernel can't be used to test zfs.ko. |
@Low-power - I have access to POWER8 and POWER9 OpenStack VMs - is there some ready to use FreeBSD 13.x Disk Image somewhere? I would like to setup an big endian FreeBSD buildbot then. Also one for ppc64le ... maybe I don't have to search a lot, when you can tell me some fast link ;-) |
Unfortunately I didn't have my hands on FreeBSD/powerpc64 right this time. I only experienced working FreeBSD/powerpc64 live system under QEMU/KVM, so I guess using the standard iso images should be fine. |
acf7ce9
to
5e41463
Compare
@mcmilk Can you may rebase this? And is this blocked due to no-testing-capability for big endian systems? Can we may use buildbot or qemu for this? |
I have FreeBSD and Linux POWER8, POWER9 and POWER10 machines now. |
The variants Skein-256 and Skein-1024 aren't used within OpenZFS. Signed-off-by: Tino Reichardt <[email protected]>
The variants Skein-256 and Skein-1024 aren't used within OpenZFS.
Motivation and Context
Cleanup icp module - encryption and hashing.
Description
The code is public domain, so there is ne need for additional licensing information:
THIRDPARTYLICENSE*
removed, and CDDL headers added. Also the debugging and the two unused variants got removed.How Has This Been Tested?
I compiled on FreeBSD and Linux machines.
No big endian machine currently :(
Types of changes
Checklist:
Signed-off-by
.