Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variants of Skein #14708

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mcmilk
Copy link
Contributor

@mcmilk mcmilk commented Apr 2, 2023

The variants Skein-256 and Skein-1024 aren't used within OpenZFS.

Motivation and Context

Cleanup icp module - encryption and hashing.

Description

The code is public domain, so there is ne need for additional licensing information: THIRDPARTYLICENSE* removed, and CDDL headers added. Also the debugging and the two unused variants got removed.

How Has This Been Tested?

I compiled on FreeBSD and Linux machines.
No big endian machine currently :(

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@Low-power
Copy link
Contributor

No big endian machine currently

It builds on my big-endian POWER7 machine, with Linux 4.1 and 6.1. No further testings are done because current running kernel can't be used to test zfs.ko.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Apr 5, 2023
@mcmilk
Copy link
Contributor Author

mcmilk commented Apr 12, 2023

No big endian machine currently

It builds on my big-endian POWER7 machine, with Linux 4.1 and 6.1. No further testings are done because current running kernel can't be used to test zfs.ko.

@Low-power - I have access to POWER8 and POWER9 OpenStack VMs - is there some ready to use FreeBSD 13.x Disk Image somewhere? I would like to setup an big endian FreeBSD buildbot then. Also one for ppc64le ... maybe I don't have to search a lot, when you can tell me some fast link ;-)

@Low-power
Copy link
Contributor

Unfortunately I didn't have my hands on FreeBSD/powerpc64 right this time. I only experienced working FreeBSD/powerpc64 live system under QEMU/KVM, so I guess using the standard iso images should be fine.

@mcmilk mcmilk force-pushed the skein-cleanup branch 2 times, most recently from acf7ce9 to 5e41463 Compare June 3, 2024 20:05
@jumbi77
Copy link
Contributor

jumbi77 commented Oct 18, 2024

@mcmilk Can you may rebase this? And is this blocked due to no-testing-capability for big endian systems? Can we may use buildbot or qemu for this?

@mcmilk
Copy link
Contributor Author

mcmilk commented Oct 18, 2024

I have FreeBSD and Linux POWER8, POWER9 and POWER10 machines now.
But the time is a bit limited. I will just rebase this first... and maybe test later on Big Endian also.

The variants Skein-256 and Skein-1024 aren't used within OpenZFS.

Signed-off-by: Tino Reichardt <[email protected]>
@behlendorf behlendorf added the Status: Work in Progress Not yet ready for general review label Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Code Review Needed Ready for review and testing Status: Work in Progress Not yet ready for general review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants