Clarify description of zfs_special_class_metadata_reserve_pct #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on spa_misc.c L1974 the codepath treats DDT objects the same as regular metadata, so the language in the docs regarding "prevents small blocks or dedup table from completely consuming" was changed to clarify this
gmelikov
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Thank you, the change looks consistent with man page https://github.com/openzfs/zfs/blob/2e6b3c4d9453360a351af6148386360a3a7209b3/man/man4/zfs.4#L1976
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current language in Module Parameters#zfs-special-class-metadata-reserve-pct states
However based on spa_misc.c#L1974 the codepath treats DDT objects the same as regular metadata, so the language in the docs was changed to clarify (emphasis in blockquote only)
If the intent is to have DDT obey the reserve percentage then I can make the necessary changes to
spa_misc.cinstead.