Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root on ZFS: use compat=legacy with boot pool #466

Merged
merged 2 commits into from Nov 2, 2023
Merged

Root on ZFS: use compat=legacy with boot pool #466

merged 2 commits into from Nov 2, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 26, 2023

As mentioned here, compat=legacy seems to fix the problem where, once a snapshot of the root level dataset of the boot pool is taken, boot pool will become irreversibly unreadable by GRUB.

Also added a note against using less well-tested features in general.

Yǔchēn Guō 郭宇琛 added 2 commits November 2, 2023 10:28
@gmelikov
Copy link
Member

gmelikov commented Nov 2, 2023

legacy is too strict, but why not, at least temporarily. We may add a note about grub bug in future, if upstream won't fix it in a year.

@gmelikov gmelikov merged commit cd1a2d2 into openzfs:master Nov 2, 2023
2 checks passed
@ghost ghost deleted the grub-compat-legacy branch November 5, 2023 15:31
@colmbuckley
Copy link
Contributor

If we genuinely think that one or more of the current feature list in /usr/share/zfs/compatibility.d/grub2 is not, actually compatible with GRUB2, then we should be making upstream PRs to fix that. The whole point of that file is to identify which features are usable with GRUB2; it is vastly preferable to fix this file than to suggest that GRUB2 only works with compatibility=legacy bpools.

Which features are causing the problem?

@colmbuckley
Copy link
Contributor

If people are following this guide, bpool needs very few zpool features in order to remain useful, we should definitely prune compatibility.d/grub2 to only contain features we are highly confident to work.

@ghost
Copy link
Author

ghost commented Nov 8, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants