PR #17383: Parameterize elemental_ir_emitter_test.cc float tests #17386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_676627549
branch
from
eab9f1a
to
474fa91
Compare
Imported from GitHub PR #17383 `elemental_ir_emitter_test.cc` contains multiple similar tests for `bf16`, `f8e4m3fnuz` and , `f8e5m2fnuz`. Changes: - Parameterize the float tests in elemental_ir_emitter_test.cc. - Add additional types to the list of tested types - `f8e5m2`, `f8e4m3fn`, `f8e4m3b11fnuz`. Some tests failed for newly added types. Temporary use `GTEST_SKIP` for such cases: Related issues: - #17323 - #17324 Copybara import of the project: -- 47dcfcf by Alexander Pivovarov <[email protected]>: Parameterize elemental_ir_emitter_test.cc float tests Merging this change closes #17383 COPYBARA_INTEGRATE_REVIEW=#17383 from apivovarov:param_elemental_ir_emitter_test 47dcfcf PiperOrigin-RevId: 676739814
copybara-service
bot
force-pushed
the
test_676627549
branch
from
474fa91
to
7201c6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #17383: Parameterize elemental_ir_emitter_test.cc float tests
Imported from GitHub PR #17383
elemental_ir_emitter_test.cccontains multiple similar tests forbf16,f8e4m3fnuzand ,f8e5m2fnuz.Changes:
f8e5m2,f8e4m3fn,f8e4m3b11fnuz.Some tests failed for newly added types. Temporary use
GTEST_SKIPfor such cases:Related issues:
Copybara import of the project:
--
47dcfcf by Alexander Pivovarov [email protected]:
Parameterize elemental_ir_emitter_test.cc float tests
Merging this change closes #17383
FUTURE_COPYBARA_INTEGRATE_REVIEW=#17383 from apivovarov:param_elemental_ir_emitter_test 47dcfcf