shellcheck

openxla · Nov 18, 2024 · bafd5e3 · bafd5e3
1 parent 6342efe
commit bafd5e3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/build_tools/integrate/README.md b/build_tools/integrate/README.md
@@ -9,8 +9,10 @@ ecosystem in a reasonable amount of time.
 
 ### Bump LLVM Revision
 
-First we bump LLVM to match that of XLA, and apply any patches the the XLA
-LLVM integrate had to apply to StableHLO to build LLVM:
+The XLA repo has constant integrates of LLVM and carries a patch file for
+StableHLO in [temporary.patch(https://github.com/openxla/xla/blob/main/third_party/stablehlo/temporary.patch),
+which contains any changes needed to build StableHLO at a new LLVM revision.
+To sync to XLA's LLVM revision and apply necessary patches, use:
 
 ```sh
 $ ./build_tools/integrate/llvm_bump_revision.sh

diff --git a/build_tools/integrate/stablehlo_tag_and_bump_version.sh b/build_tools/integrate/stablehlo_tag_and_bump_version.sh
@@ -27,7 +27,8 @@ VERSION_H="$SCRIPT_DIR/../../stablehlo/dialect/Version.h"
 VERSION_CPP="$SCRIPT_DIR/../../stablehlo/dialect/Version.cpp"
 setup_version_vars() {
   # getCurrentVersion() { Version(0, X, Y); }
-  local VERSION_STR=$(grep getCurrentVersion -A1 "$VERSION_H" | grep -o 'Version([0-9], .*)')
+  local VERSION_STR
+  VERSION_STR=$(grep getCurrentVersion -A1 "$VERSION_H" | grep -o 'Version([0-9], .*)')
   local REGEX="Version\(([0-9]+), ([0-9]+), ([0-9]+)\)"
   if [[ $VERSION_STR =~ $REGEX ]]
   then
@@ -116,7 +117,8 @@ tag_and_bump() {
 update_forward_compat_versions() {
   echo "Bumping 4w and 12w compatibility window values"
 
-  local UTC_TIME=$(date -u +%s)
+  local UTC_TIME
+  UTC_TIME=$(date -u +%s)
 
   local WEEK_4_TAG=""
   local WEEK_12_TAG=""