Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.05] nodogsplash: update to 5.0.1 #998

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

mwarning
Copy link
Contributor

Cherry picked from #997 since this includes an important security fix to protect against path tracersal attacks.

Signed-off-by: Moritz Warning <[email protected]>
(cherry picked from commit 91e0790)
@mwarning
Copy link
Contributor Author

@bluewavenet @lynxis fyi

@mwarning mwarning changed the title [openwrt-23.05] nodogsplash: update to 5.0.1 [23.05] nodogsplash: update to 5.0.1 Jul 24, 2023
@mwarning
Copy link
Contributor Author

@PolynomialDivision hi, can you have a second look here? Thank you.

@BKPepe
Copy link
Member

BKPepe commented Jul 25, 2023

Hmm, too bad that in the commit message, there are not explained changes like why they are additional dependencies, why the conflict was changed, etc. Because it looks like usual bump, which it isnt. :-(

@mwarning
Copy link
Contributor Author

mwarning commented Jul 25, 2023

Ah, I see. Yes, too bad. For the record, the dependencies were missing. The nodogsplash2 package does not exist anymore.

@mwarning
Copy link
Contributor Author

@BKPepe there is probably no point in adding it to the commit now in this MR. If that's ok, then let's merge it.

@mwarning mwarning merged commit 55187d4 into openwrt:openwrt-23.05 Jul 27, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants