Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batman-adv: Provide teardown hook for batadv_vlan proto #1045

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

ecsv
Copy link
Contributor

@ecsv ecsv commented Feb 5, 2024

Maintainer: @simonwunderlich
Compile tested: ath79, GL.iNet GL-AR750
Run tested: ath79, GL.iNet GL-AR750

Description:

The batadv_vlan proto doesn't need to do anything when it gets teared down. But the scripts are still trying to call the teardown function of this proto. This results in warnings like:

daemon.notice netifd: batmesh1 (18940): ./batadv_vlan.sh: eval: line 37: proto_batadv_vlan_teardown: not found

Just providing a stub function avoids this log spam.

Fixes: #1044
Reported-by: Rani Hod [email protected]
Fixes: f5205d7 ("batman-adv: upgrade package to latest release 2014.2.0")

The batadv_vlan proto doesn't need to do anything when it gets teared down.
But the scripts are still trying to call the teardown function of this
proto. This results in warnings like:

    daemon.notice netifd: batmesh1 (18940): ./batadv_vlan.sh: eval: line 37: proto_batadv_vlan_teardown: not found

Just providing a stub function avoids this log spam.

Fixes: openwrt#1044
Reported-by: Rani Hod <[email protected]>
Fixes: f5205d7 ("batman-adv: upgrade package to latest release 2014.2.0")
Signed-off-by: Sven Eckelmann <[email protected]>
@simonwunderlich simonwunderlich merged commit 61f15a7 into openwrt:master Feb 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

batman-adv: proto_batadv_vlan_teardown not implemented in batadv_vlan.sh
2 participants