Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conserver: backport support for high baud rates. #25038

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

daztucker
Copy link
Contributor

@daztucker daztucker commented Sep 26, 2024

Backport upstream support for high baud rates (230.4k up to 4M baud).

Maintainer: @neheb
Compile tested: mips_24kc, gl.inet 6416, openwrt current
Run tested: mips_24kc, gl.inet 6416, openwrt current, tested at 1.5Mbit with a USB ch341-uart

Description:
This backports from upstream e7ca230c2239735d1b4c05747da8efbbae2fb547 (which adds support for baud rates above 115.2k) and 1a961cdf18e2de6240c78f127029f76b147226fc (which fixes a bug displaying those speeds) which were added upstream after the 8.2.6 release.

@BKPepe
Copy link
Member

BKPepe commented Sep 26, 2024

I do have a question, though. Why do we need to have backports, when we can update conserver to version 8.2.7, which is tagged, released and includes those commits?

Backport upstream support for high baud rates (230.4k up to 4M baud).

Signed-off-by: Darren Tucker <[email protected]>
@daztucker
Copy link
Contributor Author

I do have a question, though. Why do we need to have backports, when we can update conserver to version 8.2.7, which is tagged, released and includes those commits?

I wanted to submit this (and the previous ipv6 segfault fix) for the 23.05 branch since that's what I use, and I wasn't sure if a full version bump on a stable branch was desirable. I was planning to submit a PR for the 8.2.7 bump for master only after that (it's in my repo at fbe889a). If you're fine with 8.2.7 for both I can just do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants